Remove content sourced from external repository#26
Conversation
- Delete modern-apis.md and text-formatting.md reference files - Remove related sections from SKILL.md (modern API rules, checklist items, quick reference table) - Clean up image-optimization.md, scroll-patterns.md, and layout-best-practices.md - Update AGENTS.md, README.md, and plugin metadata to reflect removals
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 995eff23f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Good - logic in testable model (iOS 16 and earlier) | ||
| @MainActor | ||
| final class LoginViewModel: ObservableObject { | ||
| final class AuthService: ObservableObject { |
There was a problem hiding this comment.
This example now declares AuthService without @MainActor even though the view launches login() from a Task; in SwiftUI code copied from this pattern, any @Published writes after an await can resume off the main actor and trigger background-thread publishing violations at runtime. Since this reference is meant to provide correct defaults for iOS 16-era ObservableObject usage, the sample should remain main-actor isolated (or explicitly call out the required isolation).
Useful? React with 👍 / 👎.
1 participant
We used several inputs for improving this skill, but we lacked proper permissions. This PR removes anything that came from Paul's SwiftAgents repository.